[Fizz] Hoist hoistables to each row and transfer the dependencies to future rows #33312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
5 tasks
gnoff
approved these changes
May 20, 2025
There was a problem hiding this comment.
It might be worth optimizing the serialization of the href dependencies for link stylesheets. At the moment we include the href for each boundary reveal. With the accumulation of all preceding hrefs when unblocking rows we might be repeated the same href many times. This is true before in a way but only if each boundary actually depended on that link. In this case we can have unbounded growth of hrefs by the number of rows.
Maybe we track which hrefs are emitted in which order and just start encoding a number
eps1lon
approved these changes
May 20, 2025
sebmarkbage
force-pushed
the
fizzsupenselistcss
branch
from
1d7164f to
8bea435
Compare
…scovered boundaries Not just already blocked boundaries.
sebmarkbage
force-pushed
the
fizzsupenselistcss
branch
from
8bea435 to
8cf6f47
Compare
github-actions bot
pushed a commit
that referenced
this pull request
May 20, 2025
…future rows (#33312) Stacked on #33311. When a row contains Suspense boundaries that themselves depend on CSS, they will not resolve until the CSS has loaded on the client. We need future rows in a list to be blocked until this happens. We could do something in the runtime but a simpler approach is to just add those CSS dependencies to all those boundaries as well. To do this, we first hoist the HoistableState from a completed boundary onto its parent row. Then when the row finishes do we hoist it onto the next row and onto any boundaries within that row. DiffTrain build for [50389e1](50389e1)
This was referenced May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #33311.
When a row contains Suspense boundaries that themselves depend on CSS, they will not resolve until the CSS has loaded on the client. We need future rows in a list to be blocked until this happens. We could do something in the runtime but a simpler approach is to just add those CSS dependencies to all those boundaries as well.
To do this, we first hoist the HoistableState from a completed boundary onto its parent row. Then when the row finishes do we hoist it onto the next row and onto any boundaries within that row.