[compiler] Prevent overriding a derivationEntry on effect mutation and instead update typeOfValue and fix infinite loops

[jorge-cab]

Summary:
With this we are now comparing a snapshot of the derivationCache with the new changes every time we are done recording the derivations happening in the HIR.

We have to do this after recording everything since we still do some mutations on the cache when recording mutations.

Test Plan:
Test the following in playground:

// @validateNoDerivedComputationsInEffects_exp

function Component({ value }) {
  const [checked, setChecked] = useState('');

  useEffect(() => {
    setChecked(value === '' ? [] : value.split(','));
  }, [value]);

  return (
    <div>{checked}</div>
  )
}

This no longer causes an infinite loop.

Added a test case in the next PR in the stack

---

Stack created with Sapling. Best reviewed with ReviewStack.

• [compiler] Switch to track setStates by aliasing and id instead of identifier names #34973
• [compiler] Update ValidateNoDerivedComputationsInEffects_exp to log the error instead of throwing #34972
• [compiler] Fix false negatives and add data flow tree to compiler error for no-deriving-state-in-effects #34995
• -> [compiler] Prevent overriding a derivationEntry on effect mutation and instead update typeOfValue and fix infinite loops #34967