fix(number-input): preserve value on Enter with useActionState (#33667) #34977
Conversation
… used with useActionState - Modified setDefaultValue function to allow updating defaultValue for focused number inputs when the value has changed - This ensures that form actions can properly update the visual value of number inputs after completion - Added comprehensive test to verify the fix works correctly - Resolves issue facebook#33667 The fix allows defaultValue updates for focused number inputs when the value has actually changed, which is necessary when form actions complete and need to update the visual value. This maintains backward compatibility while fixing the specific issue with useActionState.
|
Hi @tharani-2006! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
What changes are being made and why?
This PR fixes the issue where a type="number" input using useActionState clears its value when pressing Enter.
Previously, the input named "From:" would get cleared, even though the defaultValue contained the typed number.
The expected behavior is that the number input should behave like other inputs (e.g., "Name"), preserving its value after hitting Enter.
This change ensures that number inputs retain the typed value after form submission via Enter.
How the changes have been QAed?
Tested locally in a React 19 environment.
Typed a number in the "From:" input and pressed Enter → value remains visible as expected.
Confirmed "Name" input behavior is unchanged.
Verified that the form submission still works correctly and useActionState continues to receive updated values.