Skip to content

Fix :active being outranked by :hover in a media query #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexcarpenter wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix :active being outranked by :hover in a media query #1789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 46 additions & 46 deletions packages/@stylexjs/babel-plugin/__tests__/legacy/stylex-transform-call-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,12 +688,12 @@ describe('@stylexjs/babel-plugin', () => {
priority: 3000
});
_inject2({
ltr: "@media (min-width: 1000px){.xc445zv.xc445zv{background-color:blue}}",
priority: 3200
ltr: "@media (min-width: 1000px){.xc445zv{background-color:blue}}",
priority: 3000.2
});
_inject2({
ltr: "@media (min-width: 2000px){.x1ssfqz5.x1ssfqz5{background-color:purple}}",
priority: 3200
ltr: "@media (min-width: 2000px){.x1ssfqz5{background-color:purple}}",
priority: 3000.2
});
"xrkmrrc xc445zv x1ssfqz5";"
`);
Expand Down Expand Up @@ -723,12 +723,12 @@ describe('@stylexjs/babel-plugin', () => {
priority: 3000
});
_inject2({
ltr: "@media (min-width: 1000px) and (max-width: 1999.99px){.xw6up8c.xw6up8c{background-color:blue}}",
priority: 3200
ltr: "@media (min-width: 1000px) and (max-width: 1999.99px){.xw6up8c{background-color:blue}}",
priority: 3000.2
});
_inject2({
ltr: "@media (min-width: 2000px){.x1ssfqz5.x1ssfqz5{background-color:purple}}",
priority: 3200
ltr: "@media (min-width: 2000px){.x1ssfqz5{background-color:purple}}",
priority: 3000.2
});
"xrkmrrc xw6up8c x1ssfqz5";"
`);
Expand Down Expand Up @@ -760,12 +760,12 @@ describe('@stylexjs/babel-plugin', () => {
priority: 3000
});
_inject2({
ltr: "@supports (hover: hover){.x6m3b6q.x6m3b6q{background-color:blue}}",
priority: 3030
ltr: "@supports (hover: hover){.x6m3b6q{background-color:blue}}",
priority: 3000.03
});
_inject2({
ltr: "@supports not (hover: hover){.x6um648.x6um648{background-color:purple}}",
priority: 3030
ltr: "@supports not (hover: hover){.x6um648{background-color:purple}}",
priority: 3000.03
});
"xrkmrrc x6m3b6q x6um648";"
`);
Expand Down Expand Up @@ -795,12 +795,12 @@ describe('@stylexjs/babel-plugin', () => {
priority: 3000
});
_inject2({
ltr: "@supports (hover: hover){.x6m3b6q.x6m3b6q{background-color:blue}}",
priority: 3030
ltr: "@supports (hover: hover){.x6m3b6q{background-color:blue}}",
priority: 3000.03
});
_inject2({
ltr: "@supports not (hover: hover){.x6um648.x6um648{background-color:purple}}",
priority: 3030
ltr: "@supports not (hover: hover){.x6um648{background-color:purple}}",
priority: 3000.03
});
"xrkmrrc x6m3b6q x6um648";"
`);
Expand Down Expand Up @@ -1496,8 +1496,8 @@ describe('@stylexjs/babel-plugin', () => {
priority: 3130
});
_inject2({
ltr: "@media (min-width: 1000px){.xc445zv.xc445zv{background-color:blue}}",
priority: 3200
ltr: "@media (min-width: 1000px){.xc445zv{background-color:blue}}",
priority: 3000.2
});
export const styles = {
default: {
Expand Down Expand Up @@ -1535,8 +1535,8 @@ describe('@stylexjs/babel-plugin', () => {
priority: 3130
});
_inject2({
ltr: "@media (min-width: 1000px){.xc445zv.xc445zv{background-color:blue}}",
priority: 3200
ltr: "@media (min-width: 1000px){.xc445zv{background-color:blue}}",
priority: 3000.2
});
export const styles = {
default: {
Expand Down Expand Up @@ -1745,8 +1745,8 @@ describe('@stylexjs/babel-plugin', () => {
priority: 3130
});
_inject2({
ltr: "@media (min-width: 1000px){.xc445zv.xc445zv{background-color:blue}}",
priority: 3200
ltr: "@media (min-width: 1000px){.xc445zv{background-color:blue}}",
priority: 3000.2
});
export const styles = {
default: {
Expand Down Expand Up @@ -1922,16 +1922,16 @@ describe('@stylexjs/babel-plugin', () => {
priority: 2000
});
_inject2({
ltr: "@media (max-width: 640px){.gridTemplateRows-xmr4b4k.gridTemplateRows-xmr4b4k{grid-template-rows:minmax(0,1fr) auto}}",
priority: 3200
ltr: "@media (max-width: 640px){.gridTemplateRows-xmr4b4k{grid-template-rows:minmax(0,1fr) auto}}",
priority: 3000.2
});
_inject2({
ltr: "@media (max-width: 640px){.gridTemplateAreas-xesbpuc.gridTemplateAreas-xesbpuc{grid-template-areas:\\"content\\" \\"sidebar\\"}}",
priority: 2200
ltr: "@media (max-width: 640px){.gridTemplateAreas-xesbpuc{grid-template-areas:\\"content\\" \\"sidebar\\"}}",
priority: 2000.2
});
_inject2({
ltr: "@media (max-width: 640px){.gridTemplateColumns-x15nfgh4.gridTemplateColumns-x15nfgh4{grid-template-columns:100%}}",
priority: 3200
ltr: "@media (max-width: 640px){.gridTemplateColumns-x15nfgh4{grid-template-columns:100%}}",
priority: 3000.2
});
_inject2({
ltr: ".gridTemplateColumns-x1mkdm3x{grid-template-columns:minmax(0,1fr)}",
Expand Down Expand Up @@ -2023,16 +2023,16 @@ describe('@stylexjs/babel-plugin', () => {
priority: 2000
});
_inject2({
ltr: "@media (max-width: 640px){.gridTemplateRows-xmr4b4k.gridTemplateRows-xmr4b4k{grid-template-rows:minmax(0,1fr) auto}}",
priority: 3200
ltr: "@media (max-width: 640px){.gridTemplateRows-xmr4b4k{grid-template-rows:minmax(0,1fr) auto}}",
priority: 3000.2
});
_inject2({
ltr: "@media (max-width: 640px){.gridTemplateAreas-xesbpuc.gridTemplateAreas-xesbpuc{grid-template-areas:\\"content\\" \\"sidebar\\"}}",
priority: 2200
ltr: "@media (max-width: 640px){.gridTemplateAreas-xesbpuc{grid-template-areas:\\"content\\" \\"sidebar\\"}}",
priority: 2000.2
});
_inject2({
ltr: "@media (max-width: 640px){.gridTemplateColumns-x15nfgh4.gridTemplateColumns-x15nfgh4{grid-template-columns:100%}}",
priority: 3200
ltr: "@media (max-width: 640px){.gridTemplateColumns-x15nfgh4{grid-template-columns:100%}}",
priority: 3000.2
});
_inject2({
ltr: ".gridTemplateColumns-x1mkdm3x{grid-template-columns:minmax(0,1fr)}",
Expand Down Expand Up @@ -2168,16 +2168,16 @@ describe('@stylexjs/babel-plugin', () => {
priority: 2000
});
_inject2({
ltr: "@media (max-width: 640px){.gridTemplateRows-xmr4b4k.gridTemplateRows-xmr4b4k{grid-template-rows:minmax(0,1fr) auto}}",
priority: 3200
ltr: "@media (max-width: 640px){.gridTemplateRows-xmr4b4k{grid-template-rows:minmax(0,1fr) auto}}",
priority: 3000.2
});
_inject2({
ltr: "@media (max-width: 640px){.gridTemplateAreas-xesbpuc.gridTemplateAreas-xesbpuc{grid-template-areas:\\"content\\" \\"sidebar\\"}}",
priority: 2200
ltr: "@media (max-width: 640px){.gridTemplateAreas-xesbpuc{grid-template-areas:\\"content\\" \\"sidebar\\"}}",
priority: 2000.2
});
_inject2({
ltr: "@media (max-width: 640px){.gridTemplateColumns-x15nfgh4.gridTemplateColumns-x15nfgh4{grid-template-columns:100%}}",
priority: 3200
ltr: "@media (max-width: 640px){.gridTemplateColumns-x15nfgh4{grid-template-columns:100%}}",
priority: 3000.2
});
_inject2({
ltr: ".gridTemplateColumns-x1mkdm3x{grid-template-columns:minmax(0,1fr)}",
Expand Down Expand Up @@ -2311,16 +2311,16 @@ describe('@stylexjs/babel-plugin', () => {
priority: 2000
});
_inject2({
ltr: "@media (max-width: 640px){.gridTemplateRows-xmr4b4k.gridTemplateRows-xmr4b4k{grid-template-rows:minmax(0,1fr) auto}}",
priority: 3200
ltr: "@media (max-width: 640px){.gridTemplateRows-xmr4b4k{grid-template-rows:minmax(0,1fr) auto}}",
priority: 3000.2
});
_inject2({
ltr: "@media (max-width: 640px){.gridTemplateAreas-xesbpuc.gridTemplateAreas-xesbpuc{grid-template-areas:\\"content\\" \\"sidebar\\"}}",
priority: 2200
ltr: "@media (max-width: 640px){.gridTemplateAreas-xesbpuc{grid-template-areas:\\"content\\" \\"sidebar\\"}}",
priority: 2000.2
});
_inject2({
ltr: "@media (max-width: 640px){.gridTemplateColumns-x15nfgh4.gridTemplateColumns-x15nfgh4{grid-template-columns:100%}}",
priority: 3200
ltr: "@media (max-width: 640px){.gridTemplateColumns-x15nfgh4{grid-template-columns:100%}}",
priority: 3000.2
});
_inject2({
ltr: ".gridTemplateColumns-x1mkdm3x{grid-template-columns:minmax(0,1fr)}",
Expand Down
4 changes: 2 additions & 2 deletions packages/@stylexjs/babel-plugin/__tests__/transform-import-export-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,10 +312,10 @@ describe('@stylexjs/babel-plugin', () => {
[
"x14693no",
{
"ltr": "@media (min-width: 768px){.x14693no.x14693no{color:blue}}",
"ltr": "@media (min-width: 768px){.x14693no{color:blue}}",
"rtl": null,
},
3200,
3000.2,
],
[
"x15oojuh",
Expand Down
Loading
Loading