Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unnecessary pickle file checks #1694

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

tmct
Copy link
Contributor

@tmct tmct commented Jun 22, 2022

Doesn't really save time but there's no need for checking the filesystem again once it exists

@facebook-github-bot
Copy link

Hi @tmct!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 22, 2022
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@jrapin
Copy link
Contributor

jrapin commented Aug 23, 2022

it probably does not save time indeed, and adds a line. Then again some file systems may be slow, so this seems safer indeed

@jrapin jrapin merged commit f4ead42 into facebookincubator:main Aug 23, 2022
@jrapin
Copy link
Contributor

jrapin commented Aug 23, 2022

Thanks for the PRs btw

@tmct tmct deleted the patch-2 branch August 26, 2022 10:23
@tmct
Copy link
Contributor Author

tmct commented Aug 26, 2022

No problem - thank you! Please could someone have a look at my PR that lets me use Windows? #1695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants