Fbgemm embedding #238
Fbgemm embedding #238
Conversation
The fbgemm_embedding benchmarks are now executed through run.sh, so the corresponding benchmark execution script needs to be updated accordingly.
"FBGEMM_VERSION=fd32631d837b41251311099c393af7d7be5cfbf" is a commit ID. Using it with "git clone -b $FBGEMM_VERSION" fails. This commit fixes that issue.
|
Hi @zhengjun-xing! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
meta-cla
bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@YifanYuan3 has imported this pull request. If you are a Meta employee, you can view this in D83988062. |
Summary: Two patches to fix FBGEMM git clone failures and runtime errors: The FBGEMM_VERSION=fd32631d837b41251311099c393af7d7be5cfbf variable points to a commit ID. Using it with git clone -b $FBGEMM_VERSION fails. This patch corrects that issue. The fbgemm_embedding benchmarks are now run through run.sh, so the benchmark execution script has been updated accordingly. Pull Request resolved: #238 Reviewed By: excelle08 Differential Revision: D83988062 Pulled By: YifanYuan3 fbshipit-source-id: df7bdcb385a67de65dff66cfa3cee535565fb867
2 participants
Two patches to fix FBGEMM git clone failures and runtime errors:
The FBGEMM_VERSION=fd32631d837b41251311099c393af7d7be5cfbf variable points to a commit ID. Using it with git clone -b $FBGEMM_VERSION fails. This patch corrects that issue.
The fbgemm_embedding benchmarks are now run through run.sh, so the benchmark execution script has been updated accordingly.