Skip to content

Fix BPE vocabulary loading when using ImageBind as library #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix BPE vocabulary loading when using ImageBind as library #84

wants to merge 1 commit into from

Conversation

TimeEscaper
Copy link

Dear authors,

I faced an issue when tried to use ImageBind as an installed library in third-party project. It couldn't find BPE vocabulary (see also Issue 15 since it was not copied to the pip paths. Seems that this PR fixes this problem.

@facebook-github-bot
Copy link

Hi @TimeEscaper!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 1, 2023
@raghavdixit99 raghavdixit99 mentioned this pull request Feb 21, 2024
Closed
leewaylicn
leewaylicn approved these changes May 15, 2024
View reviewed changes
Copy link

@leewaylicn leewaylicn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meet same issue，this change can fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@leewaylicn leewaylicn leewaylicn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TimeEscaper @facebook-github-bot @leewaylicn