- 
                Notifications
    
You must be signed in to change notification settings  - Fork 180
 
Speed up model loading #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
        
          
                bytelatent/model/blt.py
              
                Outdated
          
        
      | return cross_mask[b, q_idx, kv_idx] | ||
| return cross_mask_copy[b, q_idx, kv_idx] | ||
| 
               | 
          ||
| # print(f"cross_mask: {cross_mask.shape}") | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably delete commented code?
| 
           Aside from deleted commented/unused code, this looks good to me, @sriniiyer can you take a quick look?  | 
    
| 
           Commented code removed.  | 
    
| 
           Hi @gahdritz! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with  If you have received this in error or have any questions, please contact us at [email protected]. Thanks!  | 
    
Add support for initializing the model directly in a specific dtype and device. Speeds up loading the model (e.g.
load_consolidated_model_and_tokenizergoes from ~80s to ~16s for the 7B model).