Skip to content

Conversation

@gahdritz
Copy link

@gahdritz gahdritz commented Jun 5, 2025

Add support for initializing the model directly in a specific dtype and device. Speeds up loading the model (e.g. load_consolidated_model_and_tokenizer goes from ~80s to ~16s for the 7B model).

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 5, 2025
return cross_mask[b, q_idx, kv_idx]
return cross_mask_copy[b, q_idx, kv_idx]

# print(f"cross_mask: {cross_mask.shape}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably delete commented code?

@EntilZha
Copy link
Contributor

Aside from deleted commented/unused code, this looks good to me, @sriniiyer can you take a quick look?

@gahdritz
Copy link
Author

Commented code removed.

@meta-cla
Copy link

meta-cla bot commented Sep 12, 2025

Hi @gahdritz!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants