chore(react): Storybook Patterns cleanup — casing + App shell & Filters#4725
Merged
Conversation
Contributor
📦 Alpha Package Version PublishedUse Use |
Contributor
🔍 Visual review for your branch is published 🔍Here are the links to: |
Contributor
Coverage Report for packages/react
File CoverageNo changed files found. |
desiree-np
force-pushed
the
chore/f0-storybook-patterns
branch
from
July 17, 2026 09:38
fa88a5d to
2d097e5
Compare
desiree-np
added a commit
that referenced
this pull request
Jul 17, 2026
'ui/' is no longer a top-level '🔒 Internal' bucket. Its stories route to
their altitude:
- internal primitives -> Components/Primitives (Card, Select, Dialog, Spinner,
Toast, DatePickerPopup, OverflowList, IconBadge, Action, Counter, ...)
- standalone widgets -> Components (Wizard, ButtonCopy, Pagination,
ValueDisplay, ButtonGroup, Shortcut, OnePreset)
- Kanban / Lane -> Patterns/Kanban
- OneRestrictComponent -> Resources
- Omnibutton -> Components (carries the 'deprecated' badge)
'internal' is now purely an informational badge (not public API): removed the
sidebar filter that HID internal-tagged stories in the public build, so
primitives stay visible to contributors in every build — matching the lifecycle
('primitives have a page so DS contributors can find and reuse it').
Verified in Storybook: no '🔒 Internal' root; 0 title collisions.
Scope: PR 3a. Follow-ups: dissolve Deprecated (3b); cross-section moves
Tabs/Box/Reactions -> Components; internal-badge tag consistency on primitives.
Stacked on #4725.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…rs groups - Normalize 'Data collection' -> 'Data Collection' (inconsistent casing was splitting OneDataCollection into two sidebar nodes; 24 vs 6 stories/docs). - Group ApplicationFrame under Patterns/App shell (alongside the layouts). - Group FilterPicker, FilterPickerContent and DateNavigator under Patterns/Filters (DateNavigator is a temporal filter). Title-only changes; verified in Storybook: single 'Data Collection' node, new 'App shell' and 'Filters' groups, 0 title collisions. Scope: PR 2 of the Storybook reorg series. Stacked on #4723 (base branch). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
desiree-np
force-pushed
the
chore/f0-storybook-patterns
branch
from
July 20, 2026 12:01
2d097e5 to
9ca72d3
Compare
Contributor
✅ No New Circular DependenciesNo new circular dependencies detected. Current count: 0 |
Contributor
✅ No breaking public API changesNo public exports were removed, renamed, or had existing props/types changed in a breaking way compared to Comparing
|
desiree-np
added a commit
that referenced
this pull request
Jul 20, 2026
'ui/' is no longer a top-level '🔒 Internal' bucket. Its stories route to
their altitude:
- internal primitives -> Components/Primitives (Card, Select, Dialog, Spinner,
Toast, DatePickerPopup, OverflowList, IconBadge, Action, Counter, ...)
- standalone widgets -> Components (Wizard, ButtonCopy, Pagination,
ValueDisplay, ButtonGroup, Shortcut, OnePreset)
- Kanban / Lane -> Patterns/Kanban
- OneRestrictComponent -> Resources
- Omnibutton -> Components (carries the 'deprecated' badge)
'internal' is now purely an informational badge (not public API): removed the
sidebar filter that HID internal-tagged stories in the public build, so
primitives stay visible to contributors in every build — matching the lifecycle
('primitives have a page so DS contributors can find and reuse it').
Verified in Storybook: no '🔒 Internal' root; 0 title collisions.
Scope: PR 3a. Follow-ups: dissolve Deprecated (3b); cross-section moves
Tabs/Box/Reactions -> Components; internal-badge tag consistency on primitives.
Stacked on #4725.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
desiree-np
added a commit
that referenced
this pull request
Jul 20, 2026
'ui/' is no longer a top-level '🔒 Internal' bucket. Its stories route to
their altitude:
- internal primitives -> Components/Primitives (Card, Select, Dialog, Spinner,
Toast, DatePickerPopup, OverflowList, IconBadge, Action, Counter, ...)
- standalone widgets -> Components (Wizard, ButtonCopy, Pagination,
ValueDisplay, ButtonGroup, Shortcut, OnePreset)
- Kanban / Lane -> Patterns/Kanban
- OneRestrictComponent -> Resources
- Omnibutton -> Components (carries the 'deprecated' badge)
'internal' is now purely an informational badge (not public API): removed the
sidebar filter that HID internal-tagged stories in the public build, so
primitives stay visible to contributors in every build — matching the lifecycle
('primitives have a page so DS contributors can find and reuse it').
Verified in Storybook: no '🔒 Internal' root; 0 title collisions.
Scope: PR 3a. Follow-ups: dissolve Deprecated (3b); cross-section moves
Tabs/Box/Reactions -> Components; internal-badge tag consistency on primitives.
Stacked on #4725.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
PR 2 of the Storybook reorg series. Cleans up the Patterns section: fixes a casing bug and introduces two coherent groups. All changes are title-only.
Changes
Data collection→Data Collection. Inconsistent casing (24 vs 6 stories/docs) was splitting OneDataCollection into two sidebar nodes.ApplicationFramenow sits underPatterns/App shell, alongside the layouts (it is the app shell).FilterPicker,FilterPickerContentandDateNavigatorgrouped underPatterns/Filters(DateNavigator is a temporal navigation filter).Scope & stacking
Stacked on #4723 (base branch =
chore/f0-storybook-reorder). Merge #4723 first, then this rebases ontomain.Deferred to later PRs (need cross-section folder moves or the Internal/Deprecated dissolution):
Tabs → Components,Box → Components, dissolve Internal & Deprecated into badges, then functional subgroups.Test plan
Verified in Storybook via
/index.json:App shell · Filters · Data Collection · AnalyticsDashboard · Graph · Co-creation · CRUD patterns · Dialog · Forms · Navigation · …Data Collectionnode (no lowercase duplicate).DateNavigator/FilterPicker/FilterPickerContentas separate top nodes (now underFilters).🤖 Generated with Claude Code