chore: Run ruby specs and RuboCop on every pull request - #44
Merged
Conversation
jacobobq
approved these changes
Aug 11, 2026
There was a problem hiding this comment.
Looks fine to me, but maybe check with @jorgeteixe in case he has some feedback.
Contributor
I am okay with this. Still not having specs on the other two SDKs but will be added at some point too. |
jorgeteixe
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚪 Why?
The repo has no PR-level CI for Ruby, so nothing verifies a change until someone
remembers to run the suite locally. With release-please wiring and quarterly
regeneration PRs (~1300 files) ahead, that check needs to be automatic before we
publish to a public registry.
🔑 What?
.github/workflows/ci.yaml— runsrspec+rubocopon every PR touchingruby/, and on pushes tomain.ruby/Gemfile.lock— adds thex86_64-linuxplatform so the Linux runner caninstall dependencies.
CLAUDE.md— updates the note that said there was no PR-level CI.Ruby only: TS and Python have no test job yet. The job runs on Ruby 3.4 while the
gemspec declares
>= 3.1, so a version matrix is a possible follow-up.