PR preview - #149
Closed
aneeshsunganahalli wants to merge 4 commits into
Closed
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @aneeshsunganahalli! Thanks for creating the pull request.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
Make sure to star this awesome repository and follow the account!
- DevUI
Owner
|
Thank you, This discussion space is dedicated to DevUI! You can share your thoughts in different categories:
Jump in and start a discussion here 👉 https://github.com/fahimahammed/DevUI/discussions Your feedback will help shape the future of DevUI |
Contributor
Author
|
@fahimahammed Does this pull request not satisfy the requirements listed? |
Owner
|
not working properly |
Contributor
Author
|
Did you enable the PR Review option on Vercel? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Security & Fork Handling:
Two separate events/jobs:
-pull_request job: Runs tests on PR code (safe because no secrets used)
-pull_request_target job: Queries Vercel API and posts comments (secure context with access to secrets)
For forked PRs:
-No secrets are exposed to the fork's code
-Vercel's GitHub integration automatically deploys the PR (outside of GitHub Actions)
-Our workflow uses the maintainer's token to find the deployment URL
-Comment is posted on the PR with the preview URL
##For internal PRs:
-Same process, but both jobs will run
-Vercel still handles the deployment
Related Issue
Fixes #136
Changes Made
Screenshots or GIFs (if applicable)
Checklist
Additional Notes
Setup Requirements:
-Connect GitHub repo to Vercel (one-time setup):
In Vercel dashboard, connect the repository and enable PR previews
Add these secrets to your GitHub repo:
-VERCEL_TOKEN - API token from Vercel
-VERCEL_PROJECT_ID - Your Vercel project ID
-VERCEL_PROJECT_NAME - The name of your project in Vercel (for fallback URLs)