Final edits related to finalizing a PR in web-cz #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves various minor aspects of accompanying texts: - better consistency for decimals (only .1f for large EU-wide numbers), - better parametrization of lulucf info, - less redundancy for flights info in texts for emissions pie, - better stitching of the text around the snippet how flight emissions are underrepresented, - quantifying agricultural fuel emissions, - stating ETS is driving CZ electricity emissions down in recent years, - minor editing of the texts.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@mgrabovsky Could you PTAL? This is related to my changes in faktaoklimatu/web-cz#1275. If you spot any mistake, feel free to correct it here as well. |
mgrabovsky
approved these changes
Oct 4, 2023
|
Agreed, templating would be nice. Ideally something that can be used both from R and python (even though that might be an overkill). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves various minor aspects of accompanying texts: