Skip to content

Added Command Description and also command dump #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Command Description and also command dump #4

wants to merge 1 commit into from

Conversation

@wx4cb
Copy link

@wx4cb wx4cb commented May 21, 2018

No description provided.

@wx4cb wx4cb mentioned this pull request May 21, 2018
Open
fakufaku
fakufaku requested changes May 23, 2018
View reviewed changes
Copy link
Owner

@fakufaku fakufaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. I have two suggestions.

  1. Changing the code from using Serial to a stream will break the existing code, so unless there are really important benefits, I would not do that.
  2. Can we make the description optional by providing a NULL as description ? In which case no memory would be allocated.

@wx4cb
Copy link
Author

wx4cb commented May 23, 2018 •
edited
Loading

  1. EDIT: I misread the code. that shouldn't be an issue to change back

  2. as far as using a NULL, it would still have to allocate at least 1 byte and that should already be accepted by the code as using a null in the description the description would be "\0\0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fakufaku fakufaku fakufaku requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wx4cb @fakufaku