fix: handle failed to create RTCPeerConnection object error in a call #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coder-with-a-bushido
temporarily deployed
to
review
GitHub Actions
Inactive
td-famedly
reviewed
Feb 2, 2025
coder-with-a-bushido
force-pushed
the
karthi/pc-fail
branch
from
8ccf963 to
ea71067
Compare
coder-with-a-bushido
temporarily deployed
to
review
GitHub Actions
Inactive
coder-with-a-bushido
force-pushed
the
karthi/pc-fail
branch
from
ea71067 to
3ca8e8b
Compare
td-famedly
reviewed
Mar 5, 2025
There was a problem hiding this comment.
lg, do you maybe want to add a test for it? I think we could add a flag to MockWebRTCDelegate which tells it to throw an error on createPeerConnection and then we can confirm if the call is terminated as expected.
(feel free to modify the suggestion if you have better ideas!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://famedly-ip.sentry.io/issues/6207590176/?project=1448986&query=is%3Aunresolved%20null%20check%20operator&referrer=issue-stream&statsPeriod=7d&stream_index=3