Improve address type clarity and semantic typos - #3
Open
neilramaswamy wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for this great repo on DMA! It was fun to read.
I've made a few changes to the
READMEthat should clarify areas that I had to read more than once to understand. Most changes here should be benign.However, I updated the physical and bus offset addresses to match up with the datasheet; in section 1.2.3 on ARM physical addresses (page 6), the physical offset is
0x20000000and the bus offset is0x7E000000. I am a bit concerned about my change here because the code (dma-demo.c:49) does use0x3F000000; it's unclear why this works. I don't see any reference to0x3F000000in the datasheet, so I'm unsure what the README should actually contain.Thanks!