Skip to content

chore: restructure to monorepo - #1

Closed
k11q wants to merge 1 commit into
masterfrom
chore-restructure-to-monorepo
Closed

chore: restructure to monorepo#1
k11q wants to merge 1 commit into
masterfrom
chore-restructure-to-monorepo

Conversation

@k11q

@k11q k11q commented Oct 5, 2023

Copy link
Copy Markdown
Collaborator
  • chore: restructure to monorepo
  • chore: initialize remix frontend

* chore: restructure to monorepo
* chore: initialize remix frontend

@Xavier-IV Xavier-IV left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort brotha!

Left small comments, esp. the logs. Take a look when you're free.

Thanks again!

Comment thread README.md

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help to share in the Readme some basic setup + requirement, so we can contribute?

Notice the frontend readme which is great, it'll be helpful if its mentioned in the root as this is where user/contributor first see.

Appreciate the huge effort! 🎊

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry ni dah stale sebenarnya. aku work on kat new branch #9 . jap aku add readme situ

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mantap, thank you!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not be intended commit?

Best to add in gitignore. To retain the logs folder, add .keep

e.g. /logs/.keep

So that the folder will still exists for log and won't throw "folder does not exists".

@k11q k11q closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants