Added flexability, handles colspans, window.resize event #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck in that I think are worthwhile: - Takes colspans into account - Clones and hides the original THEAD and TFOOT rather than removing them. This helps to preserve column alignment - Inserts TH/TD elements to account for addition of scroll bar (preserves column alignment, particularly if the column is right justified - Adds a window.resize event handler to update the table's display if the window changes dimensions.
|
I used this version. Only difference I found is that the resizing works when the screen has been minimized and maximized again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the reworked formatting. There are a few nuggets in this check in that I think are worthwhile: