Skip to content

#9301 find_dataset_object, delete_dataset_objectに渡すobject_nameに/が含まれていると404エラーになる #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2025
Merged

#9301 find_dataset_object, delete_dataset_objectに渡すobject_nameに/が含まれていると404エラーになる #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ad1240
objectNameのエンコード処理を追加しendpointを修正
kmkkiii Mar 26, 2025
92c7ac8
example修正
kmkkiii Mar 26, 2025
c1e2c09
fix black
kmkkiii Mar 26, 2025
d672b9e
fix isort
kmkkiii Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/delete_dataset_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
client = fastlabel.Client()

client.delete_dataset_object(
dataset_id="YOUR_DATASET_OBJECT_ID", object_name="YOUR_OBJECT_NAME"
dataset_id="YOUR_DATASET_ID", object_name="YOUR_OBJECT_NAME"
)
2 changes: 1 addition & 1 deletion examples/find_dataset_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
client = fastlabel.Client()

dataset_object = client.find_dataset_object(
dataset_id="YOUR_DATASET_OBJECT_ID", object_name="YOUR_OBJECT_NAME"
dataset_id="YOUR_DATASET_ID", object_name="YOUR_OBJECT_NAME"
)
pprint(dataset_object)
11 changes: 9 additions & 2 deletions fastlabel/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import logging
import os
import re
import urllib.parse
from concurrent.futures import ThreadPoolExecutor, wait
from pathlib import Path
from typing import Dict, List, Literal, Optional, Union
Expand Down Expand Up @@ -4251,7 +4252,10 @@ def find_dataset_object(
raise FastLabelInvalidException(
"only use specify one of revisionId or version.", 400
)
endpoint = "datasets-v2/" + dataset_id + "/objects/" + object_name
encoded_object_name = urllib.parse.quote(object_name, safe="")
endpoint = (
"dataset-objects-v2/" + dataset_id + "/objects/" + encoded_object_name
)
params = {}
if revision_id:
params["revisionId"] = revision_id
Expand Down Expand Up @@ -4474,7 +4478,10 @@ def delete_dataset_object(self, dataset_id: str, object_name: str) -> None:
"""
Delete a dataset object.
"""
endpoint = "datasets-v2/" + dataset_id + "/objects/" + object_name
encoded_object_name = urllib.parse.quote(object_name, safe="")
endpoint = (
"dataset-objects-v2/" + dataset_id + "/objects/" + encoded_object_name
)
self.api.delete_request(endpoint)

def update_aws_s3_storage(
Expand Down