ProjectMetadataのアップデートメソッド追加 #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmkkiii
reviewed
Jun 26, 2025
There was a problem hiding this comment.
ありがとうございます！
追記しました🙏
rikunosuke
reviewed
Jun 27, 2025
fastlabel/__init__.py
Outdated
Comment on lines
4119
to
4121
| external_code_1: str | None, | ||
| external_code_2: str | None, | ||
| external_code_3: str | None, |
There was a problem hiding this comment.
str | None
この書き方は python 3.10 からの書き方になります！
サポートしているバージョンは現在は 3.8 からなので、Optional[str] に変更をお願いします！
（もし他にこの書き方をしている箇所があれば教えていただけますと🙇）
There was a problem hiding this comment.
バージョン考慮できておりませんでした。申し訳ありません🙇♂️
返却値の型にも誤りがあったため併せて修正いたしました！
bee220c
他の箇所でパイプを使っている箇所は見当たりませんでした🙏
rikunosuke
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
プロジェクトメタデータの追加に伴い、メタデータ更新用のメソッドを追加しました。
テスト