-
Notifications
You must be signed in to change notification settings - Fork 53
[trunc/quant_avg_pool] Update Trunc and QuantAveragePool to match how Brevitas Ops work #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nickfraser
wants to merge
8
commits into
fastmachinelearning:main
Choose a base branch
from
nickfraser:fix/trunc_avg_pool
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[trunc/quant_avg_pool] Update Trunc and QuantAveragePool to match how Brevitas Ops work #170
nickfraser
wants to merge
8
commits into
fastmachinelearning:main
from
nickfraser:fix/trunc_avg_pool
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Thanks @nickfraser ! For matching the new (fixed) behavior in Xilinx/brevitas#1042 the changes seem appropriate. A few thoughts on how to proceed:
|
…tead of attributes
4 tasks
FYI, I believe I've addressed all the comments mentioned above. For the backwards compatibility story, I've introduced versioning into QONNX. The latest release of Brevitas now generates QONNX opset version 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brevitas used to have some weird behaviour W.R.T. how average pool and trunc used to work (both separately and together). The original behaviour and a new proposal is detailed here. The purpose of this PR is to make changes on the QONNX side which match the new proposal.
TODO:
Trunc
behaviour to match the new behaviour in Brevitastrunc_op
spec to match the new functionalityUpdate- TODO in a separate PRQuantAveragePool2D
to match the new behaviour in Brevitas