data.table: use growable vectors #809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating
data.tablelists or their names, set theGROWABLE_BITon them. This ensures thatR_resizeVectorused bydata.tablewon't refuse to work with suchdata.tables. Drop the finalizer asgc()will count the memory taken by growable vectors correctly.Main Changes
SET_GROWABLE_BITwhen settingTRUELENGTHinshallow()andsetnames()Checklist
R CMD checkpasses (except for cryptic vignette problems) withdata.tablefrom CRAN and from currentmaster.Additional Context
Please let me know how you would like to deal with
SET_GROWABLE_BITnot being an API entry point. It could be hidden as are other non-API entry points, or the code could make use ofR_allocResizableVectorand backport it for R < 4.6.