Skip parsing of the VTIMEZONE entries#23
Open
rhumbertgz wants to merge 1 commit intofazibear:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @fazibear
I noticed that the current implementation of the
parsefunction and its helperput_to_mapmodify the starting date of the newest event due to the processing of VTIMEZONE entries.For example, the start date of last event (Test #5) of this log is 2019-10-25, however as
put_to_mapalways update the latest event, and the VTIMEZONE entry also have a DTSTART field the event will get the value of the last DTSTART of the *VTIMEZONE entry, in this example 1996-10-27This pull request skip the processing the processing of VTIMEZONE entries so the start date of the last event is not modified.
Note: I'm using the Apple Calendar
.....
"BEGIN:VEVENT"
"CREATED:20191025T115913Z"
"UID:866BE96C-3A70-4F7A-9A72-EF496C2DD7CF"
"DTEND;TZID=Europe/Brussels:20191025T163000"
"TRANSP:OPAQUE"
"X-APPLE-TRAVEL-ADVISORY-BEHAVIOR:AUTOMATIC"
"SUMMARY:Test #5"
"LAST-MODIFIED:20191025T115933Z"
"DTSTAMP:20191025T115933Z"
"DTSTART;TZID=Europe/Brussels:20191025T151500"
"SEQUENCE:0"
"END:VEVENT"
"BEGIN:VTIMEZONE"
"TZID:Europe/Brussels"
"BEGIN:DAYLIGHT"
"TZOFFSETFROM:+0100"
"RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU"
"DTSTART:19810329T020000"
"TZNAME:GMT+02:00"
"TZOFFSETTO:+0200"
"END:DAYLIGHT"
"BEGIN:STANDARD"
"TZOFFSETFROM:+0200"
"RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU"
"DTSTART:19961027T030000"
"TZNAME:GMT+01:00"
"TZOFFSETTO:+0100"
"END:STANDARD"
"END:VTIMEZONE"
"BEGIN:VTIMEZONE"
"TZID:Asia/Tokyo"
"BEGIN:DAYLIGHT"
"TZOFFSETFROM:+0900"
"RRULE:FREQ=YEARLY;UNTIL=19510505T170000Z;BYMONTH=5;BYDAY=1SU"
"DTSTART:19500507T020000"
"TZNAME:GMT+9"
"TZOFFSETTO:+1000"
"END:DAYLIGHT"
"BEGIN:STANDARD"
"TZOFFSETFROM:+1000"
"DTSTART:19510908T020000"
"TZNAME:GMT+9"
"TZOFFSETTO:+0900"
"END:STANDARD"
"END:VTIMEZONE"
"BEGIN:VTIMEZONE"
"TZID:Europe/Berlin"
"BEGIN:DAYLIGHT"
"DTSTART:19810329T020000"
"RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU"
"TZNAME:GMT+2"
"TZOFFSETFROM:+0100"
"TZOFFSETTO:+0200"
"END:DAYLIGHT"
"BEGIN:STANDARD"
"DTSTART:19961027T030000"
"RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU"
"TZNAME:GMT+1"
"TZOFFSETFROM:+0200"
"TZOFFSETTO:+0100"
"END:STANDARD"
"END:VTIMEZONE"