Upgrade dependencies and many more fun!#9
Open
aitorjs wants to merge 14 commits intofbessou:masterfrom
Open
Conversation
added 14 commits
April 28, 2017 13:25
of angular2-schema-form (1.0.0-beta.7)
- Charging this.model directly.
- Main tag changed from app-root to sf-demo-app.
- Http module deleted from demo.
fbessou
requested changes
May 4, 2017
Owner
fbessou
left a comment
fbessou
left a comment
There was a problem hiding this comment.
Thank you very much for these contribution ! 😀
That was a lot of reading :)
Before I merge could you
- remove/revert the commit ae8e02b
as it is not related to this repository - remove end-to-end tests as they are not testing anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements made: