When parsing with correction flag, u,i,v should not be considered as …

…invalid Fix #67
fcitx · May 1, 2024 · 9ed5f07 · 9ed5f07
1 parent 21328ab
commit 9ed5f07
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/libime/pinyin/pinyinencoder.cpp b/src/libime/pinyin/pinyinencoder.cpp
@@ -99,7 +99,8 @@ struct LongestMatchResult {
 template <typename Iter>
 LongestMatchResult longestMatch(Iter iter, Iter end, PinyinFuzzyFlags flags,
                                 const PinyinMap &map) {
-    if (*iter == 'i' || *iter == 'u' || *iter == 'v') {
+    if ((*iter == 'i' || *iter == 'u' || *iter == 'v') &&
+        !flags.test(PinyinFuzzyFlag::Correction)) {
         return {false, std::string_view(&*iter, std::distance(iter, end)),
                 false};
     }

diff --git a/test/testpinyinencoder.cpp b/test/testpinyinencoder.cpp
@@ -238,6 +238,11 @@ int main() {
         auto graph = PinyinEncoder::parseUserPinyin(
             "zhyi", &profile, PinyinFuzzyFlag::Correction);
         dfs(graph, {"zhyi"});
+
+        graph = PinyinEncoder::parseUserPinyin("xianguaoyige", &profile,
+                                               PinyinFuzzyFlag::Correction);
+        dfs(graph, {"xiang", "uao", "yi", "ge"});
+        dfs(graph, {"xian", "gu", "ao", "yi", "ge"});
     }
 
     return 0;