Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit / ruff errors #82

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Fix pre-commit / ruff errors #82

merged 1 commit into from
Feb 23, 2024

Conversation

dekkers
Copy link
Collaborator

@dekkers dekkers commented Feb 14, 2024

I saw that the repository wasn't clean with regards to pre-commit / ruff. This PR fixes all the ruff errors.

I decided to silence the PTH123 error because Django returns strings and it doesn't make a lot of sense to me to convert the string to a Path object for a single open call just to make ruff happy.

It might also be a good idea to add https://pre-commit.ci/ to the repository to have pre-commit run in CI.

Copy link

semanticdiff-com bot commented Feb 14, 2024

Review changes with SemanticDiff.

Analyzed 4 of 4 files.

Overall, the semantic diff is 50% smaller than the GitHub diff.

2 files do not contain logic changes.

Filename Status
✔️ django_weasyprint/__init__.py 38.7% smaller
✔️ django_weasyprint/tests/__init__.py No logic changes found
✔️ django_weasyprint/utils.py 12.5% smaller
✔️ django_weasyprint/views.py No logic changes found

@fdemmer fdemmer merged commit 2d1b717 into fdemmer:main Feb 23, 2024
5 checks passed
@dekkers dekkers deleted the pre-commit branch February 23, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants