Skip to content

[PATCH FIRST] FECFILE-2934: e2e click(s) save(s) and more#3668

Open
sVmsepi0l wants to merge 10 commits intorelease/sprint-81from
fix/occams-click-save
Open

[PATCH FIRST] FECFILE-2934: e2e click(s) save(s) and more#3668
sVmsepi0l wants to merge 10 commits intorelease/sprint-81from
fix/occams-click-save

Conversation

@sVmsepi0l
Copy link
Contributor

@sVmsepi0l sVmsepi0l commented Mar 11, 2026

Ticket: FECFILE-2934

this is in reponse to the failures that occurred after this merge

multiple other test failures've sprung up since the aforementioned merge of FECFILE-2879 into develop due to several other subsequent merges), so the failures keep compounding

it’s not just the save clicks that were broken.

currently in develop and release/sprint-81 as of 03/13/2026:
20/22 tests failing in e2e-smoke
9/9 tests failing in e2e-extended

…Save assertions, new data-cy attributes for the different save clicks, and fixed a new login issue i encountered
@sVmsepi0l sVmsepi0l requested a review from toddlees March 11, 2026 18:33
@sVmsepi0l sVmsepi0l changed the title FECFILE-2934: e2e click(s) save(s) [HOLD] FECFILE-2934: e2e click(s) save(s) Mar 11, 2026
@sVmsepi0l
Copy link
Contributor Author

sVmsepi0l commented Mar 11, 2026

need to make a quick fix to the clicks save in Contacts and loans

@sVmsepi0l
Copy link
Contributor Author

sVmsepi0l commented Mar 12, 2026

still working on a fix, these save clicks're still a beast. fewer files, though

@sVmsepi0l sVmsepi0l changed the title [HOLD] FECFILE-2934: e2e click(s) save(s) [READY] FECFILE-2934: e2e click(s) save(s) Mar 12, 2026
@sVmsepi0l sVmsepi0l changed the title [READY] FECFILE-2934: e2e click(s) save(s) [WIP] FECFILE-2934: e2e click(s) save(s) Mar 12, 2026
@sVmsepi0l
Copy link
Contributor Author

sVmsepi0l commented Mar 12, 2026

last spec that's failing is F3X/disbursements.cy.ts , just one of the tests: ('should be able to link an Independent Expenditure to a Form 24')

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sVmsepi0l sVmsepi0l changed the title [WIP] FECFILE-2934: e2e click(s) save(s) [READY] FECFILE-2934: e2e click(s) save(s) Mar 12, 2026
@sVmsepi0l
Copy link
Contributor Author

@toddlees passing on feature branch
image

@sVmsepi0l sVmsepi0l changed the title [READY] FECFILE-2934: e2e click(s) save(s) FECFILE-2934: e2e click(s) save(s) Mar 12, 2026
Copy link
Contributor

@toddlees toddlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hold

@sVmsepi0l sVmsepi0l changed the base branch from develop to release/sprint-81 March 12, 2026 21:26
@sVmsepi0l sVmsepi0l changed the title FECFILE-2934: e2e click(s) save(s) [PATCH] FECFILE-2934: e2e click(s) save(s) Mar 13, 2026
@sVmsepi0l sVmsepi0l changed the title [PATCH] FECFILE-2934: e2e click(s) save(s) [PATCH] FECFILE-2934: e2e click(s) save(s) and more Mar 13, 2026
@sVmsepi0l sVmsepi0l changed the title [PATCH] FECFILE-2934: e2e click(s) save(s) and more [PATCH FIRST] FECFILE-2934: e2e click(s) save(s) and more Mar 13, 2026
@sVmsepi0l sVmsepi0l changed the title [PATCH FIRST] FECFILE-2934: e2e click(s) save(s) and more [FIRST] FECFILE-2934: e2e click(s) save(s) and more Mar 13, 2026
@sVmsepi0l sVmsepi0l changed the title [FIRST] FECFILE-2934: e2e click(s) save(s) and more [PATCH FIRST] FECFILE-2934: e2e click(s) save(s) and more Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants