Skip to content

test: fix flaky /help assertion blocking publish #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
federiconeri merged 1 commit into from
Apr 8, 2026
Merged

test: fix flaky /help assertion blocking publish #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions src/tui/screens/MainShell.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,22 @@ vi.mock('../hooks/useSync.js', () => ({

const testHeader = <Text>HEADER</Text>;

async function waitForFrameContains(
instance: ReturnType<typeof render>,
needle: string,
timeoutMs = 1500,
): Promise<string> {
const start = Date.now();
let frame = stripAnsi(instance.lastFrame() ?? '');

while (!frame.includes(needle) && Date.now() - start < timeoutMs) {
await wait(25);
frame = stripAnsi(instance.lastFrame() ?? '');
}

return frame;
}

describe('MainShell', () => {
let onNavigate: ReturnType<typeof vi.fn<(target: NavigationTarget, props?: NavigationProps) => void>>;

Expand All @@ -49,11 +65,9 @@ describe('MainShell', () => {
);

// Use /h alias which is shorter and more reliable in CI
await typeText(instance, '/h ');
await typeText(instance, '/help ');
pressEnter(instance);
await wait(100);

const frame = stripAnsi(instance.lastFrame() ?? '');
const frame = await waitForFrameContains(instance, 'Available commands');
expect(frame).toContain('Available commands');
instance.unmount();
});
Expand Down Expand Up @@ -110,9 +124,7 @@ describe('MainShell', () => {

await typeText(instance, '/h ');
pressEnter(instance);
await wait(50);

const frame = stripAnsi(instance.lastFrame() ?? '');
const frame = await waitForFrameContains(instance, 'Available commands');
expect(frame).toContain('Available commands');
instance.unmount();
});
Expand Down
Loading