Skip to content

feat: implement onboarding flow with mnemonic generation and wallet integration#243

Open
Robinaditya1045 wants to merge 2 commits intofedimint:mainfrom
Robinaditya1045:feat/onboarding
Open

feat: implement onboarding flow with mnemonic generation and wallet integration#243
Robinaditya1045 wants to merge 2 commits intofedimint:mainfrom
Robinaditya1045:feat/onboarding

Conversation

@Robinaditya1045
Copy link
Copy Markdown

closes #237

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 14, 2026

⚠️ No Changeset found

Latest commit: 9f6cf03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Robinaditya1045 Robinaditya1045 marked this pull request as ready for review February 18, 2026 22:27
@Robinaditya1045
Copy link
Copy Markdown
Author

Please review @MrImmortal09

Comment on lines +7 to +34
type ParsedInviteCode = {
federation_id: string
url: string
}

type ParsedBolt11Invoice = {
amount: number
expiry: number
memo: string
}

type PreviewFederation = {
federation_id: string
config: {
global: {
meta?: {
federation_name?: string
}
consensus_version: {
major: number
minor: number
}
api_endpoints: Record<string, { name?: string; url?: string }>
}
modules: Record<string, { kind?: string }>
}
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import these from @fedimint/types

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrImmortal09
Copy link
Copy Markdown
Member

Thanks for the contribution! nice PR overall.
Could you please make the requested changes so we can move forward with it?

Copy link
Copy Markdown
Member

@MrImmortal09 MrImmortal09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

The join federation creates a new client, you can't open a client which doesn't exist at all.

@Robinaditya1045
Copy link
Copy Markdown
Author

Thanks for the contribution! nice PR overall.
Could you please make the requested changes so we can move forward with it?

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement proper onboarding flow in web examples

2 participants