Skip to content

ci: optimize test workflows for directory-specific changes (#265)#266

Open
7fighter wants to merge 7 commits intofedimint:mainfrom
7fighter:ci/path-based-tests
Open

ci: optimize test workflows for directory-specific changes (#265)#266
7fighter wants to merge 7 commits intofedimint:mainfrom
7fighter:ci/path-based-tests

Conversation

@7fighter
Copy link
Copy Markdown

@7fighter 7fighter commented Apr 3, 2026

This PR implements directory-specific test triggering to optimize CI resources as requested in #265.

Changes

  • Added dorny/paths-filter to pull-request.yml to detect changes in core, web, and react-native directories.
  • Updated verify.yml to accept these detections as inputs and conditionalize job execution.
  • Ensured lint runs for any relevant changes while heavy builds are scoped to their specific domains.
  • Fixed Prettier formatting issues in the workflow files.

Verification (Tested on fork)

  • React Native change: Only Lint and RN Build triggered.
  • Core/Web change: Relevant test suites triggered.
  • Workflow change: Full suite triggered (expected behavior).

Fixes #265

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 3, 2026

⚠️ No Changeset found

Latest commit: 1d0b60b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MrImmortal09
Copy link
Copy Markdown
Member

MrImmortal09 commented Apr 4, 2026

@7fighter Check out the changeset.yml to understand how the react-native building works.

You will need a mac os runner for building the ios, so that should be a seperate task, keep rest tasks on self hosted linux runners.

@MrImmortal09
Copy link
Copy Markdown
Member

MrImmortal09 commented Apr 7, 2026

@alexlwn123 Should we run all the tests if any of the workflow changes?

This event happens rarely, but ig the tests should be checked before we merge.

@alexlwn123
Copy link
Copy Markdown
Member

Should we run all the tests if any of the workflow changes?

This event happens rarely, but ig the tests should be checked before we merge.

Agree, seems like a good sanity check.

@MrImmortal09
Copy link
Copy Markdown
Member

@7fighter Please run all the tests if any of the workflow changes.

@MrImmortal09
Copy link
Copy Markdown
Member

MrImmortal09 commented Apr 16, 2026

image

@7fighter Do check this out.

Copy link
Copy Markdown
Member

@MrImmortal09 MrImmortal09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submodules isn't getting initialised properly in a few checks.

Comment on lines +137 to +138
uses: ./.github/actions/build-react-native
timeout-minutes: 90
Copy link
Copy Markdown
Member

@MrImmortal09 MrImmortal09 Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the react-native-android tries to build android(pnpm ubrn:android) but fails due to absense of fedimint-sdk-ffi, and the react-native-ios tries to build both android and ios bindings. The android bindings are thus build twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize Test Workflows for Directory-Specific Changes

3 participants