fix: degrade to cached and image results when the search engines are down - #2484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when every text-search engine fails (a rate limit or CAPTCHA suspends a SearXNG engine for an hour to a day), the search fails outright, even if the exact same query has a cached result, and the AI response has nothing to ground on.
This PR does three things:
(image)in the prompt.Where to start
Most of the diff is tests (11 new ones, +354 lines). The behavior changes are in
client/modules/search.ts(stale fallback plus a read-time age check),client/modules/textGeneration.ts(the image-fallback grounding, and a guard so an older search cannot repopulate a newer one's grounding channel),server/webSearchService.ts(the fail-fast) and the banner inclient/components/Search/Results/Textual/TextSearchResults.tsx.How to test
npm test(the new tests cover the stale fallback, the image grounding and the fail-fast).npm run lint.docs/failure-injection.mdmatrix).