personalize links based on host #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacongobbler
requested changes
Nov 7, 2024
|
Here is a more polish architecture diagram: |
Signed-off-by: karthik2804 <[email protected]>
karthik2804
force-pushed
the
personalize-frontend
branch
from
a88589c to
90bdc31
Compare
Signed-off-by: karthik2804 <[email protected]>
bacongobbler
requested changes
Nov 7, 2024
Signed-off-by: karthik2804 <[email protected]>
There was a problem hiding this comment.
Right now, this fails to run due to this issue: spinframework/spin#2915. For now, i think we should resolve this by switching to self requests. Alternatively we could merge this and tell users to either comment out the MQTT component or run the app selectively without the mqtt component:
SPIN_VARIABLE_MQTT_BROKER_URI="test.mosquitto.org" SPIN_VARIABLE_MQTT_TOPIC="booth/+" spin up --component-id "frontend" --component-id "api" --component-id "frontend-customization" --component-id "redirect-index"Signed-off-by: karthik2804 <[email protected]>
Signed-off-by: Kate Goldenring <[email protected]>
kate-goldenring
approved these changes
Nov 7, 2024
|
@bacongobbler it looks like all of your suggestions were resolved. Do you mind re-reviewing? |
bacongobbler
approved these changes
Nov 7, 2024
Signed-off-by: MacKenzie Olson <[email protected]>
Updating color scheme with better text to backgorund contrast
|
Merging this; any follow-ups can be done post-merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The links on the UI are customized based on the server's hostname. This can be tested by setting different host headers for the different providers.