-
Notifications
You must be signed in to change notification settings - Fork 3
docs: add target property for links in navigation #2025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-Authored-By: Catherine Deskur <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
| @@ -0,0 +1,11 @@ | |||
| ## Link target property | |||
|
|
|||
| You can now specify where links open using the `target` property. This applies to product links, tab links, page links, and navbar links. Options are `_blank` (new tab), `_self` (same tab, default), `_parent`, and `_top`. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[FernStyles.Current] Avoid time-relative terms like 'now' that become outdated
Co-Authored-By: Catherine Deskur <[email protected]>
docs: add target property for links in navigation
Summary
Documents the new
targetproperty for links in the docs navigation system. This property allows users to specify where links open (new tab, same tab, etc.) and applies to:Added concise documentation in five locations:
targetParamField for navbar-links configurationAlso fixed a Vale style warning by removing the time-relative term "now" from the changelog.
Review & Testing Checklist for Human
targetproperty actually works for all four link types (product, tab, page, navbar) in a real docs.yml configuration. I documented this based on the Slack announcement but haven't tested it myself.targetshould be documented. Specifically, check if dropdown menu items within navbar-links supporttarget, or if there are other link types I missed._blank,_self,_parent, and_topare the complete and correct set of valid values. These are standard HTML target values, but the implementation might support a different subset.Notes