Dockerfile updates for better dev/build times#11
Open
sharmarajdaksh wants to merge 1 commit intofestivitymishra:masterfrom
Open
Dockerfile updates for better dev/build times#11sharmarajdaksh wants to merge 1 commit intofestivitymishra:masterfrom
sharmarajdaksh wants to merge 1 commit intofestivitymishra:masterfrom
Conversation
- Rearranged Dockerfile commands to install dependencies only when dependencies change. - As it was earlier, the pip dependencies were reinstalled after every change in code (.py) files, which was completely unnecessary - Added Cmake as an OS dependency as builds were failing without it Closes festivitymishra#10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rearranged Dockerfile commands to install dependencies only when
dependencies change.
change in code (.py) files, which was completely unnecessary
Added Cmake as an OS dependency as builds were failing without it
Tested to build successfully locally.
Related to #10