-
Notifications
You must be signed in to change notification settings - Fork 1
Add support for sendable conformance argument #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nolinmcfarland
wants to merge
15
commits into
main
Choose a base branch
from
feature/support-unchecked-sendable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing no longer assumes fixed argument positions and allows partial argument lists.
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 68.64% 68.77% +0.13%
==========================================
Files 69 71 +2
Lines 4538 4557 +19
==========================================
+ Hits 3115 3134 +19
Misses 1423 1423 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Added support for sendable conformance (
.checked
|.unchecked
) on generated mocks. This is provided as an argument on the@Mocked
macro:.checked
(also the Default) is a no-op right now since the mock's sendability is inherited through the implementation and implicitly checked by the compiler already..unchecked
conforms the generated mock to@unchecked Sendable
, supporting a fix for the issue described in [Feature] Support unchecked Sendable #86.To accomplish this, this pull request:
SendableConformance
macro argument.MacroArgument
protocol and refactors argument parsing to allow for partial arguments (ex., havingsendableConformance
but notcompilationCondition
), giving us greater flexibility for future arguments.@unchecked Sendable
a reusable extension ofInheritedTypeSyntax
.@unchecked Sendable
to the inheritance clause when.unchecked
is passed in for thesendableConformance
argument.🛠️ Type of Change
🧪 How Has This Been Tested?
I replicated the scenario and error described in #86 and verified it is resolved when conforming the mock to
@unchecked Sendable
. Unit tests verifying the macro's expansion passed. Please see screenshots of the expansions below:.checked
).checked
.unchecked
🔗 Related PRs or Issues
✅ Checklist
SwiftFormat