-
Notifications
You must be signed in to change notification settings - Fork 275
feat(integration): Adding langchain and crewai adapter for uAgents #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
can find example and readme for how to use it here : https://github.com/abhifetch/uAgents-Adapter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
I strongly believe that this belongs in the 3-applications
folder of the official uAgents examples repo as it introduces dependencies into the core framework and is more of an integration than a core functionality of uagents.
Also, the target folder here would be /contrib
rather than /experimental
@Archento Thanks for the suggestion, I have discussed this with @ejfitzgerald and got this into the experimental folder. I know this is integration, we want developers to use these integrations and directly get their agent on agentverse with chat protocol enabled. @ejfitzgerald can you please comment on what should be preferred here. |
These look really cool, but as others have already pointed out, |
Changes made as per suggestions by @qati #679 (comment)
49c28ab
to
ffeaf80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things here:
- why is the register tool not a separate class that both derivates can use
- why do you use threading when most of the current architecture can make better use of multiprocessing or even simply asyncio tasks in a single thread
- adding to the above: hardcoded time.sleep should generally be avoided and instead sequential event based approaches used
- the chat handlers have overly complex case logic which is prone to errors and could potentially be simplified
- the pyproject file could be updated to adhere to the current python standard which is tool agnostic (avoid, if possible, that Poetry needs to be used)
- pytest is imported but there are no tests
- since >=python3.10 is defined, please also adhere to the new typing requirements
All of these should eventually be tackled but I assume this can happen down the line / as a patch afterwards.
Otherwise looks good to me 👍🏻
Thankyou @Archento , I will address all of these in the coming release. |
Proposed Changes
Addititon of langchain uagents adapter in experiment
Linked Issues
[if applicable, add links to issues resolved by this PR]
Types of changes
What type of change does this pull request make (put an
x
in the boxes that apply)?Checklist
Put an
x
in the boxes that apply:If applicable
python/scripts/generate_api_docs.py
)Further comments
[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]