Fix t/op/chdir.t - All 51 tests passing (100%) #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three fixes to get chdir.t working: 1. Exporter.java: Add support for :DEFAULT export tag - :DEFAULT now correctly expands to @export contents - Fixes File::Spec::Functions import issue 2. perl_test_runner.pl: Fix working directory for t/ tests - Tests in t/op/, t/base/, etc. now run from t/ directory - Allows tests to require './test.pl' correctly 3. Directory.java: Complete chdir() implementation - chdir('') now fails with ENOENT (errno 2) - chdir() checks HOME, LOGDIR, SYS$LOGIN env vars - SYS$LOGIN only checked on VMS, not darwin/macOS - Proper errno values: ENOENT (2) and EINVAL (22) - fchdir throws 'unimplemented' error for filehandles Test Results: - Before: 0/0 tests (compilation error) - After: 51/51 tests passing (100%)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three fixes to get chdir.t working:
Exporter.java: Add support for :DEFAULT export tag
perl_test_runner.pl: Fix working directory for t/ tests
Directory.java: Complete chdir() implementation
Test Results: