Allow lambda sections to render text #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, forgot about this 😞 Let me do a quick review. |
| @@ -113,7 +113,11 @@ | |||
|
|
|||
| (deftest test-render-lambda-with-params | |||
| (is (= "Hello, Felix" (render "{{#greet}}Felix{{/greet}}" | |||
| {:greet #(str "Hello, " %)})))) | |||
| {:greet (fn [text] (str "Hello, " text))}))) | |||
There was a problem hiding this comment.
Why not the lambda literal? Semantically it's the same.
|
That's the only comment really, don't see the reason for this change. Looks good to merge otherwise! |
|
Thanks for taking a look, I've made the change you requested in your comment. |
fhd
added a commit
that referenced
this pull request
May 4, 2014
Allow lambda sections to render text
|
Brilliant, merged! Sorry again for missing this 😞 Will do a release shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing issue #31 #31