Fixed compiling with ESP32 + bug fix #142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FStefanni
changed the title
|
@fhessel any chance we could please get this merged? |
|
+1 for early merge |
|
@fhessel I don't feel confident enough to review the keepalive change (which I don't understand). But +1 on the sha-header change. I have a merge request ready also for esp32_https_server_compat that is waiting for this merge request... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this pr is a small fix for compiling with ESP32.
Fixes #136
Moreover, this pr fixes the default behavior for
Connectionheader.Please see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Connection
Regards