Add invite code functionality#20
Conversation
|
@staab please review |
|
I would personally have the relay generate the code and expiration policy rather than the requester. This is how https://github.com/nostr-protocol/nips/pull/1079/files works. But it's completely unspecified, so this approach is also fine. The code and expiration stuff should probably be optional, and possible for the relay to reject if they fall outside of certain boundaries. But the PR looks fine to me. |
|
Unconvincing review, I'll have to review it myself. |
|
found this while trying to figure out how invite codes work for nip-29 groups. lgtm, we should probably update the NIP-29 spec since as @staab mentions the invite codes are underspecified. |
…BasedOnGroupRules
|
It's been a while, any intent to merge this? |
|
No, I have abandoned this codebase. I will come back and refactor it once NIP-29 gets enough traction. |
statewith expiration supportkind 9021join requests