-
Notifications
You must be signed in to change notification settings - Fork 126
fix(firebase_ui_auth): Avoid redundant confirmation on account deletion #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(firebase_ui_auth): Avoid redundant confirmation on account deletion #494
Conversation
9061f02
to
e3c0323
Compare
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Get ou bot |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Get out bot @russellwheatley please take a look :) |
…-account-deletion
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Get away bot |
Ty a lot |
Description
When user try to delete his account, when the exception 'requires-recent-login' appear, user need to login again and click again on the modal to confirm the account deletion. That's redundant.
Related Issues
This PR can also bring some beneficts to this PR : #493, if developer override the deletion modal to provide one (for example) using a TextController to ensure that user well want to delete his account (no miss click), the recall of the confirmation will present twice a TextController to fill.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.melos run test:unit:all
doesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?