feat: Implement Twitter provider #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rname instead of email
…provider + button
Lyokone
reviewed
Oct 21, 2025
| try await authService.signIn(googleProvider) | ||
| } | ||
| } | ||
| .accessibilityIdentifier("sign-in-with-google-button") |
There was a problem hiding this comment.
Is it for testing? Maybe we could define a variable for it?
There was a problem hiding this comment.
The test process is separate from the app used to test the UI so I don't think it's worth it.
Lyokone
approved these changes
Oct 21, 2025
demolaf
reviewed
Oct 21, 2025
FirebaseSwiftUI/FirebaseTwitterSwiftUI/Sources/Services/AccountService+Twitter.swift
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthProviderUIfor Twitter for rendering buttonAuthProviderSwiftfor Twitter for signing in via Twitter.