Skip to content

refactor: google, facebook, phone providers #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: twitter-package
Choose a base branch
from
Draft

refactor: google, facebook, phone providers #1277

wants to merge 4 commits into from

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Oct 10, 2025 •
edited
Loading

Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:

  • separate provider with UI button from provider
  • pass in provider into withPROVIDERSignIn()
  • update deleteUser logic in auth service to use internal provider to delete user with reauthentication.

@russellwheatley russellwheatley changed the title refactor: google provider refactor: google, facebook, phone providers Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@russellwheatley