Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firestore-translate-text] Source text is translated from Latin and not English #2099

Closed
amin79 opened this issue May 19, 2024 · 5 comments · May be fixed by #2254
Closed

[firestore-translate-text] Source text is translated from Latin and not English #2099

amin79 opened this issue May 19, 2024 · 5 comments · May be fixed by #2254
Assignees
Labels
extension: firestore-translate-text Related to firestore-translate-text extension type: feature request New feature or request

Comments

@amin79
Copy link

amin79 commented May 19, 2024

  • Extension name: _ [firestore-translate-text]
  • Extension version: _ 0.1.16
  • Configuration values (redact info where appropriate):
    • _
    • _

[REQUIRED] Step 3: Describe the problem

Some texts are translated automatically from Latin which are not in my language's list.

For example I have this text which is the name of some cities and location: ASPENDOS & PERGE & SIDE. This text would be translated from Latin to English as "GET UP & GO ON & SIT"!! If the source language be any other language expect Latin, the translation would be ok. But it would be translated automatically from Latin. How can I prevent it?

Steps to reproduce:

What happened? How can we make the problem occur?
This could be a description, log/console output, etc.

Expected result
Actual result
@amin79 amin79 added the type: bug Something isn't working label May 19, 2024
@pr-Mais pr-Mais added the extension: firestore-translate-text Related to firestore-translate-text extension label May 27, 2024
@pr-Mais
Copy link
Member

pr-Mais commented May 27, 2024

Thanks for reporting your issue, @amin79. I would need more information to understand the problem, could you please provide your full configuration? alongside an example of a document with input & output texts.

From what I can understand, are you referring to text romanization?

@amin79
Copy link
Author

amin79 commented Jun 3, 2024

@pr-Mais Hello. There is nothing special in the configurations. Everything works as expected.
But, just in this example, I have a text which includes the name of some cities (In English): "ASPENDOS & PERGE & SIDE"
When I save it, since these are some meaningful words in Latin, it would be translated to "GET UP & GO ON & SIT"!

Since I don't have Latin in my target languages list, I don't expect it to be transited to Latin. I like it to remain as it is because these are some NAMES.

@Gustolandia Gustolandia self-assigned this Nov 27, 2024
@cabljac
Copy link
Contributor

cabljac commented Nov 28, 2024

@amin79 It would be helpful to see your configuration regardless, to help us reproduce the issue and resolve it.

Can you provide the configuration, and the exact phrase (if possible) containing these city names, which has been mistranslated?

Since I don't have Latin in my target languages list, I don't expect it to be transited to Latin. I like it to remain as it is because these are some NAMES.

Sorry, do you mean translated from latin here? What is your target language? Target language is a key bit of information here that would help us reproduce and resolve.

@cabljac cabljac added the needs: author feedback Pending additional information from the author label Nov 28, 2024
@cabljac
Copy link
Contributor

cabljac commented Jan 6, 2025

I can confirm this is an issue/edge case with the translation API, which is out of scope for us to fix in the extension.

We could potentially add a workaround - the extension could accept an escape token for users to manually tag proper nouns.

I am going to close this issue for now, if such a feature would be helpful to you then feel free to open a fresh issue, or reply to this thread and I can open one for you.

curl -X POST \
  -H "Authorization: Bearer $(gcloud auth application-default print-access-token)" \
  -H "Content-Type: application/json" \
  -H "X-Goog-User-Project: <PROJECT_ID>" \
  -d '{
    "q": "ASPENDOS & PERGE & SIDE",
    "target": "es",
    "source": "en"
  }' \
  "https://translation.googleapis.com/language/translate/v2"
Image

@cabljac cabljac closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2025
@Gustolandia Gustolandia removed the needs: author feedback Pending additional information from the author label Jan 13, 2025
@Gustolandia
Copy link
Contributor

Hi @amin79

This PR #2254 resolves this issue by introducing V3 translation with glossaries.

It still has to pass through the review process but it should be released with the next version of the extension. Remember that Glossaries are case sensitive and that you need a source language to use them and to have the translation hub enabled in your project. This will make sure that whatever words you want (within the languages specified in the glossary) are translated (or not) in the appropriate manner.

Links and Resources

Let me know if you have any more doubts.

Thank you for submitting the feature request.

Cheers!
Gustavo ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension: firestore-translate-text Related to firestore-translate-text extension type: feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants