-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Implement Glossaries for Firestore Translate Text Extension #2254
Open
Gustolandia
wants to merge
13
commits into
next
Choose a base branch
from
@invertase/Extensions/firestore-translate-text/2099
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feature: Implement Glossaries for Firestore Translate Text Extension #2254
Gustolandia
wants to merge
13
commits into
next
from
@invertase/Extensions/firestore-translate-text/2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustolandia
added
type: feature request
New feature or request
extension: firestore-translate-text
Related to firestore-translate-text extension
labels
Jan 14, 2025
Gustolandia
force-pushed
the
@invertase/Extensions/firestore-translate-text/2099
branch
from
January 14, 2025 02:03
7d74cc0
to
b22d7c4
Compare
cabljac
requested changes
Jan 15, 2025
…v3 translation api
cabljac
reviewed
Jan 28, 2025
|
||
- [Glossary Documentation](https://cloud.google.com/translate/docs/advanced/glossary) | ||
- [Supported Languages List](https://cloud.google.com/translate/docs/languages) | ||
- [Service Account Key Documentation](https://cloud.google.com/iam/docs/creating-managing-service-account-keys) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't guide them to mention service account keys (think this is leftover from original PR, should remove it)
cabljac
reviewed
Jan 28, 2025
@@ -4,8 +4,6 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to regenerate README
dackers86
reviewed
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
extension: firestore-translate-text
Related to firestore-translate-text extension
type: feature request
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces support for glossaries in the Firestore Translate Text Extension. The feature allows for domain-specific translations, ensuring certain terms remain unaltered during translation or are translated as defined in a glossary. The implementation addresses the need for unmutable names, enhancing translation accuracy and flexibility.
Changes Made
1. Glossary Integration
GLOSSARY_ID
: Allows users to specify the ID of a glossary.SOURCE_LANGUAGE_CODE
: Required when using a glossary to define the source language.2. Extension Configuration Updates
extension.yaml
to:GLOSSARY_ID
,SOURCE_LANGUAGE_CODE
, andGOOGLE_APPLICATION_CREDENTIALS
parameters.GOOGLE_APPLICATION_CREDENTIALS
astype: secret
for enhanced security.3. Codebase Enhancements
4. Testing
mocks
to handle glossary-related scenarios, including errors and edge cases.5. Documentation
README.md
,PREINSTALL.md
, andPOSTINSTALL.md
to:Manual Testing
Performed manual testing on a separate example app:
Additional Notes
Thank you for reviewing this pull request. Please feel free to provide feedback or suggest further enhancements.
fixes: #2099