Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pnpm in place of lerna #2141

Draft
wants to merge 8 commits into
base: next
Choose a base branch
from
Draft

chore: use pnpm in place of lerna #2141

wants to merge 8 commits into from

Conversation

cabljac
Copy link
Contributor

@cabljac cabljac commented Aug 8, 2024

This PR replaces the outdated and deprecated lerna methods with pnpm.

It also fixes a bunch of npm vulnerabilities, and updates some versions.

TODO:

  • Make sure use of pnpm doesn't break release process
  • Regression testing before we release things (to check version bumps of packages haven't introduced errors

@@ -90,7 +90,7 @@ type QueryCondition = {
| "not-in"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure why we have docs for this extension here? We should remove irrelevant docs probably? @pr-Mais

@cabljac
Copy link
Contributor Author

cabljac commented Aug 8, 2024

CI is failing as it relied on lerna. need to switch to pnpm scripts.

@cabljac
Copy link
Contributor Author

cabljac commented Aug 8, 2024

CI for testing also needs to use npm probably or something? pnpm doesn't create node_modules where we need it for extensions

@cabljac cabljac changed the title [DRAFT] chore: use pnpm in place of lerna chore: use pnpm in place of lerna Aug 9, 2024
@Salakar Salakar closed this Aug 14, 2024
@Salakar Salakar reopened this Aug 14, 2024
@Salakar
Copy link
Member

Salakar commented Aug 14, 2024

woops

@Salakar Salakar requested review from Salakar and removed request for Salakar August 14, 2024 18:44
@cabljac cabljac force-pushed the next branch 2 times, most recently from 32631be to bc45fb1 Compare February 3, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants