feat(firestore-bigquery-export): add collection group query support #2518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add --is-collection-group-query flag to gen-schema-view script - Support both regular collection and collection group queries in Gemini schema generation - Update sampleFirestoreDocuments function with isCollectionGroupQuery parameter - Add interactive prompt for collection group query selection - Update documentation with examples and explanations - Add comprehensive test coverage for new functionality - Maintain backward compatibility with existing functionality This allows users to generate schemas for subcollections that appear across multiple parent documents by using collection group queries instead of regular collection queries.
- Update command line flag from --is-collection-group-query to --query-collection-group - Update all documentation and examples with new flag name - Update tests to use new flag name - Maintain same functionality with cleaner flag naming This provides a more concise and intuitive flag name for collection group queries.
Member
|
Hi @superphil0, thank you for opening this Pull Request. We will review and provide feedback. Thanks! |
HassanBahati
added
type: feature request
cabljac
reviewed
Sep 9, 2025
cabljac
requested changes
Sep 9, 2025
Contributor
cabljac
left a comment
cabljac
left a comment
There was a problem hiding this comment.
Can you remove the local dependency on the change tracker
github-project-automation
bot
moved this to Changes Requested [PR]
in [Cloud] Extensions + Functions
Author
done |
Author
firestore-bigquery-export/scripts/gen-schema-view/src/config/interactive.ts
Outdated
Show resolved
Hide resolved
firestore-bigquery-export/scripts/gen-schema-view/src/config/interactive.ts
Outdated
Show resolved
Hide resolved
…p query. - Update the message for the collection path to include both collection and collection group options.
Author
|
@cabljac can you review again? |
HassanBahati
approved these changes
Oct 7, 2025
Author
|
@cabljac anything missing here? |
Contributor
|
@superphil0 thanks for your patience! lgtm. |
Contributor
|
I want to give this a quick manual test before releasing, we will try to get this out this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to generate schemas for subcollections that appear across multiple parent documents by using collection group queries instead of regular collection queries.
This loosely follows the pattern of the import script by adding the same flag --query-collection-group
I did test this on my own production DB, so works for my purposes
Feature request here: #2516