-
Notifications
You must be signed in to change notification settings - Fork 642
Restore SessionLifecycleService as no-op #7318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,35 @@ | ||||||||||
/* | ||||||||||
* Copyright 2025 Google LLC | ||||||||||
* | ||||||||||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||||
* you may not use this file except in compliance with the License. | ||||||||||
* You may obtain a copy of the License at | ||||||||||
* | ||||||||||
* http://www.apache.org/licenses/LICENSE-2.0 | ||||||||||
* | ||||||||||
* Unless required by applicable law or agreed to in writing, software | ||||||||||
* distributed under the License is distributed on an "AS IS" BASIS, | ||||||||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||||
* See the License for the specific language governing permissions and | ||||||||||
* limitations under the License. | ||||||||||
*/ | ||||||||||
|
||||||||||
package com.google.firebase.sessions | ||||||||||
|
||||||||||
import android.app.Service | ||||||||||
import android.content.Intent | ||||||||||
|
||||||||||
/** | ||||||||||
* A no-op implementation of SessionLifecycleService. | ||||||||||
* | ||||||||||
* This service was previously used for session management but has been effectively made a no-op as | ||||||||||
* part of the architectural changes introduced in | ||||||||||
* [PR #7318](https://github.com/firebase/firebase-android-sdk/pull/7318). It is retained to prevent | ||||||||||
Comment on lines
+26
to
+27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The KDoc references PR #7318 for the architectural changes. However, based on the pull request description, the major refactoring that removed this service was done in PR #7039. To provide accurate historical context for future maintainers, it would be better to reference the original refactoring PR.
Suggested change
|
||||||||||
* `ClassNotFoundException` for older clients that might still have this service declared in their | ||||||||||
* AndroidManifest.xml or for systems attempting to restart a previously running instance of this | ||||||||||
* service. | ||||||||||
*/ | ||||||||||
internal class SessionLifecycleService : Service() { | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add Kdoc that this is a no-op impl and maybe even link this PR for context |
||||||||||
|
||||||||||
override fun onBind(unused: Intent?) = null | ||||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New files need a copyright header. You can copy it from another file in this package and make sure the year is right.