Better types for auth.makeUserRecord

[rhodgkins]

Description

Allowed partial typed UserRecord object to be specified for parameter of auth.makeUserRecord.

Code sample

N/A

[rhodgkins]

Can anyone review and, if happy, merge this in please?

[rhodgkins]

Bump @inlined & @taeold

[inlined]

I'm confused why we can't just say Partial<UserRecord>? Why do we need to specifically ensure that we omit toJSON? On one hand the code complete might be cleaner, but it requires more thought to understand the type definitions.

[rhodgkins]

I can’t remember why I removed toJSON now :-/ I don’t think a simple Partial will be enough though as it needs to recurse down to the sub objects (like it does at the moment with metadata, etc.), otherwise they will need to be fully defined.

[inlined]

I wonder if we should define RecursivePartial as demonstrated here (maybe in index.ts) and then use that in UserRecord and others. What do you think about that?

[rhodgkins]

Yeh that’s fine with me 👍