[leveldb] Remove unneeded GoogleTest submodule #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
Apr 9, 2024
|
@paulb777 , I was going to ask about that. Should those be removed? there are also some usages in the Makefile infra? |
|
I think we should keep them to minimize differences with the parent repo. |
SGTM, I like that reasoning! |
|
So I double-checked and this doesn't look to have implications on CocoaPods since the test code doesn't look to be pulled down into the workspace. This could still help decrease the pod install time. Do you feel we should do a CocoaPods and SPM release? |
|
I think we might as well to keep them in sync since this repo is rarely updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.