Fix FacetSplit.update #4238
Open
Fix FacetSplit.update #4238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/fix/facetsplit
branch
from
1115dc3 to
b0fb4df
Compare
JHopeCollins
requested changes
Apr 23, 2025
| @@ -143,11 +144,10 @@ def _restrict_nullspace(nsp): | |||
|
|
|||
| def update(self, pc): | |||
| if hasattr(self, "_permute_op"): | |||
There was a problem hiding this comment.
Please can we add a member for what configuration is being used instead of implicitly checking this based on what attributes we have? It would be clearer to the reader and more robust.
| @@ -88,10 +88,11 @@ def initialize(self, pc): | |||
| self.set_nullspaces(pc) | |||
| self.work_vecs = self.mixed_opmat.createVecs() | |||
| elif self.subset: | |||
There was a problem hiding this comment.
Configuration member requested below would probably be set before this if-else block and then used for this block, and in the update method below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
FacetSplitPCto correctly update nested preconditioners. In particular, nested python preconditioners were not correctly updated.